CHANGELOG.md

@@ -1,5 +1,4 @@
 # DEV
-* Support for newline character in filenames
 
 # 1.0.5
 ### BUGS (Minor)

atom

@@ -202,7 +202,7 @@ echo '
 	FROM	destination_files
 	WHERE	source_file_id is NULL;' >&3
 
-read -u4 -r -d $'\0' removecount
+read -u4 removecount
 until (( ${#removefile[@]} == removecount ))
 do
 	echo '
@@ -219,7 +219,7 @@ do
 		SELECT "AtOM:NoMoreFiles";
 	' >&3
 
-	read -u4 -r -d $'\0' line
+	read -u4 line
 	until [[ $line == AtOM:NoMoreFiles ]]
 	do
 		removeFileId=${line%%::AtOM:SQL:Sep::*}
@@ -227,7 +227,7 @@ do
 		removeFileDestName=${line%%::AtOM:SQL:Sep::*}
 		rest=${line#*::AtOM:SQL:Sep::}
 		removefile[$removeFileId]="${destinationpath["$removeFileDestName"]}/${rest%%::AtOM:SQL:Sep::*}"
-		read -u4 -r -d $'\0' line
+		read -u4 line
 	done
 done
 
@@ -387,7 +387,7 @@ echo '
 			<> CAST(source_files.last_change AS TEXT)
 	AND	mime_type_actions.destination_id = destinations.id
 	AND	mime_type_actions.action = 1;' >&3
-read -u4 -r -d $'\0' filecount
+read -u4 filecount
 if [ -n "$maxbatch" ] && (( maxbatch < filecount ))
 then
 	(( togo = filecount - maxbatch ))
@@ -436,11 +436,11 @@ echo '
 (( maxbatch )) && echo "LIMIT $maxbatch" >&3
 echo ';
 	SELECT "AtOM:NoMoreFiles";' >&3
-read -u4 -r -d $'\0' line
+read -u4 line
 while ! [[ $line = AtOM:NoMoreFiles ]]
 do
 	decodefiles+=("$line::AtOM:SQL:Sep::")
-	read -u4 -r -d $'\0' line
+	read -u4 line
 done
 (( cron )) || echo -n $'Creating tasks...\033[K'
 
@@ -773,11 +773,11 @@ then
 		WHERE		tasks.status = 2;
 
 		SELECT "AtOM:NoMoreFiles";' >&3
-	read -u4 -r -d $'\0' line
+	read -u4 line
 	while ! [[ $line = AtOM:NoMoreFiles ]]
 	do
 		failedtasks+=("$line")
-		read -u4 -r -d $'\0' line
+		read -u4 line
 	done
 	for line in "${failedtasks[@]}"
 	do
@@ -833,11 +833,11 @@ do
 	SELECT	"AtOM:NoMoreFiles";
 ' >&3
 
-	read -u4 -r -d $'\0' line
+	read -u4 line
 	while [[ $line != AtOM:NoMoreFiles ]]
 	do
 		renamefiles+=("$line")
-		read -u4 -r -d $'\0' line
+		read -u4 line
 	done
 	if (( ${#renamefiles[@]} ))
 	then
@@ -940,11 +940,11 @@ echo '
 
 (( cron )) || echo -n 'Removing obsolete files...'$'\033[K'
 lines=()
-read -u4 -r -d $'\0' line
+read -u4 line
 while [[ $line != AtOM:NoMoreFiles ]]
 do
 	lines+=("$line")
-	read -u4 -r -d $'\0' line
+	read -u4 line
 done
 echo 'BEGIN TRANSACTION;' >&3
 for line in "${lines[@]}"

lib/copy/action

@@ -22,11 +22,11 @@ copyFiles_action() {
 		AND	mime_type_actions.action = 2;
 
 		SELECT "AtOM:NoMoreFiles";' >&3
-	read -u4 -r -d $'\0' line
+	read -u4 line
 	while ! [[ $line = AtOM:NoMoreFiles ]]
 	do
 		copyfiles+=("$line")
-		read -u4 -r -d $'\0' line
+		read -u4 line
 	done
 
 	echo 'BEGIN TRANSACTION;' >&3
@@ -91,10 +91,9 @@ copyFiles_action() {
 			"$sourcepath/$sourcefilename"	\
 			"$destdir"
 		then
-			destfilename=${sourcefilename//$'\n'/::AtOM:NewLine:SQL:Inline::}
 			Update destination_files			\
 				filename				\
-					"$destdir/${destfilename##*/}"\
+					"$destdir/${sourcefilename##*/}"\
 				rename_pattern 				\
 					"${destinationrenamepath[$destination]}/${destinationrename[$destination]}"\
 				fat32compat				\

lib/copy/guessPath

@@ -21,7 +21,7 @@ guessPath() {
 		LIMIT 1
 	),"0.0");
 	'>&3
-	read -u4 -r -d $'\0' timestamp
+	read -u4 timestamp
 	if (( ${timestamp/./} == 0 ))
 	then
 		return 2
@@ -46,7 +46,7 @@ guessPath() {
 		LIMIT 1
 	),"AtOM:NotFound");
 	'>&3
-	read -u4 -r -d $'\0' filename
+	read -u4 filename
 	if [[ $filename != AtOM:NotFound ]]
 	then
 		echo "${filename%/*}"

lib/database/Insert

@@ -26,7 +26,6 @@ Insert() {
 				insert_values+=$value
 			;;
 			*)
-				value=${value//::AtOM:NewLine:SQL:Inline::/$'\n'}
 				insert_values+='"'"${value//\"/\"\"}"'"'
 			;;
 		esac
@@ -37,7 +36,7 @@ Insert() {
 				"( $insert_values );" >&3
 	(( no_id )) || {
 		echo 'SELECT LAST_INSERT_ROWID();' >&3
-		read -u4 -r -d $'\0' results
+		read -u 4 results
 		echo "$results"
 	}
 }

lib/database/Select

@@ -19,7 +19,6 @@ Select() {
 	while read key operator value
 	do
 		(( ${#where_statement} )) && where_statement+=( "AND" )
-		value=${value//::AtOM:NewLine:SQL:Inline::/$'\n'}
 		where_statement+=( "$key $operator "'"'"${value//\"/\"\"}"'"' )
 	done
 	echo	"SELECT IFNULL("				\
@@ -27,7 +26,7 @@ Select() {
 				"WHERE ${where_statement[@]})"	\
 			",'SQL::Select:not found'"		\
 		");" >&3
-	read -u 4 -r -d $'\0' results
+	read -u 4 results
 	if ! [[ $results == "SQL::Select:not found" ]]
 	then
 		echo "$results"

lib/database/open

@@ -6,17 +6,13 @@ openDatabase() {
 	[[ -f "$database" ]] || populate_db=1
 	rm -f "$tempdir"/sqlite.{in,out}
 	mkfifo "$tempdir"/sqlite.{in,out}
-	stdbuf -o0 sqlite3 -bail 				\
+	sqlite3 -bail "$database"	\
-		-newline $'::AtOM:SQL:EOL::\n'			\
-		"$database"					\
 		< "$tempdir/sqlite.in"	\
-		| stdbuf -o0					\
-		sed 's/::AtOM:SQL:EOL::/\x0/g;s/\(\x0\)\xA/\1/g'	\
 		> "$tempdir/sqlite.out"	&
 	db_pid=$!
 	exec 3> "$tempdir"/sqlite.in
 	exec 4< "$tempdir"/sqlite.out
-	rm "$tempdir"/sqlite.{in,out}
+	rm "$tempdir"/sqlite.in "$tempdir"/sqlite.out
 	if (( debug > 2 ))
 	then
 		exec 5>&3
@@ -28,7 +24,7 @@ openDatabase() {
 	echo 'PRAGMA recursive_triggers = ON;' >&3
 	echo 'PRAGMA temp_store = 2;' >&3
 	echo 'PRAGMA locking_mode = EXCLUSIVE;' >&3
-	read -u4 -r -d $'\0'
+	read -u4
 	unset REPLY
 	checkDatabaseVersion
 }

lib/database/upgradedatabase_1_2

@@ -18,11 +18,11 @@ FROM		destination_files;
 
 SELECT	"AtOM::NoMoreData";' >&3
 
-	read -u4 -r -d $'\0' data
+	read -u4 data
 	while [[ $data != AtOM::NoMoreData ]]
 	do
 		datas+=( "$data" )
-		read -u4 -r -d $'\0' data
+		read -u4 data
 	done
 	echo 'BEGIN TRANSACTION;' >&3
 	for data in "${datas[@]}"

lib/decode/mpcdec

@@ -2,5 +2,5 @@
 decodeMpcdec() {
 	tmpfile="${fileid}mpcdec"
 	commandline=(${ionice}mpcdec)
-	commandline+=("$sourcepath/${filename//$'\n'/::AtOM:NewLine:SQL:Inline::}" "$tempdir/$tmpfile.wav")
+	commandline+=("$sourcepath/$filename" "$tempdir/$tmpfile.wav")
 }

lib/decode/opusdec

@@ -2,5 +2,5 @@
 decodeOpusdec() {
 	tmpfile="${fileid}opusdec"
 	commandline=(${ionice}opusdec)
-	commandline+=("$sourcepath/${filename//$'\n'/::AtOM:NewLine:SQL:Inline::}" "$tempdir/$tmpfile.wav")
+	commandline+=("$sourcepath/$filename" "$tempdir/$tmpfile.wav")
 }

lib/decode/sox

@@ -12,7 +12,7 @@ decodeSox() {
 	then
 		commandline+=("$1")
 	else
-		commandline+=("$sourcepath/${filename//$'\n'/::AtOM:NewLine:SQL:Inline::}")
+		commandline+=("$sourcepath/$filename")
 	fi
 	if [ -n "${destinationfrequency["$destination"]}" ]	\
 	&& (( ${rate:-0} != ${destinationfrequency["$destination"]} ))

lib/files/getDestDir

@@ -88,7 +88,6 @@ getDestDir() {
 		while [[ $part =~ / ]]
 		do
 			thispart="${part%%/*}"
-			thispart=${thispart//$'\n'/::AtOM:NewLine:SQL:Inline::}
 			if (( ${destinationascii["$destination"]} ))
 			then
 				echo "$thispart" >&${toascii[1]}
@@ -101,7 +100,7 @@ getDestDir() {
 	fi
 	if ! [ -d "${destinationpath[$destination]}/$destdir" ]
 	then
-		mkdir -p "${destinationpath[$destination]}/${destdir//::AtOM:NewLine:SQL:Inline::/$'\n'}"
+		mkdir -p "${destinationpath[$destination]}/$destdir"
 	fi
 	destdir="${destdir//+(\/)//}"
 }

lib/files/getDestFile

@@ -55,11 +55,10 @@ getDestFile() {
 		destfile="${filename##*/}"
 		destfile="${destfile%.*}"
 	fi
-	destfile=$(sanitizeFile "$destfile")
-	destfile=${destfile//$'\n'/::AtOM:NewLine:SQL:Inline::}
 	if (( ${destinationascii["$destination"]} ))
 	then
 		echo "$destfile" >&${toascii[1]}
 		read -r -u${toascii[0]} destfile
 	fi
+	destfile=$(sanitizeFile "$destfile")
 }

lib/files/getFiles

@@ -8,7 +8,7 @@ getFiles() {
 	(( cron )) || echo -n "Scanning $sourcepath...  "
 	# We probably have thousands of files, don't waste time on disk writes
 	echo 'BEGIN TRANSACTION;' >&3
-	while read -d $'\0' time size filename
+	while read time size filename
 	do
 		if (( skip_us_timestamp ))
 		then
@@ -17,7 +17,7 @@ getFiles() {
 			compare_time=$time
 		fi
 		if ! Select source_files id >/dev/null <<-EOWhere
-				filename = ${filename//$'\n'/::AtOM:NewLine:SQL:Inline::}
+				filename = $filename
 				mime_type > 0
 				last_change LIKE $compare_time
 				size = $size
@@ -47,7 +47,7 @@ getFiles() {
 				mime_type $mimetypeid	\
 				>/dev/null		\
 			<<-EOWhere
-				filename ${filename//$'\n'/::AtOM:NewLine:SQL:Inline::}
+				filename $filename
 			EOWhere
 			(( ++new ))
 			if (( new % 1000 == 0 ))
@@ -58,12 +58,12 @@ getFiles() {
 			fi
 		else
 			Update source_files last_seen $scantime <<-EOWhere
-				filename = ${filename//$'\n'/::AtOM:NewLine:SQL:Inline::}
+				filename = $filename
 			EOWhere
 		fi
 		progressSpin
 	done < <(
-		find "$sourcepath" "${prunes[@]}" -type f -not -name '.*' -printf "%T@ %s %P\0"
+		find "$sourcepath" "${prunes[@]}" -type f -not -name '.*' -printf "%T@ %s %P\n"
 	)
 	echo 'COMMIT;' >&3
 	(( cron )) || echo -n $'\r'

lib/tags/update

@@ -52,12 +52,12 @@ echo '
 ;
 
 		SELECT "AtOM:NoMoreFiles";' >&3
-	read -u4 -r -d $'\0' line
+	read -u4 line
 	while ! [[ $line = AtOM:NoMoreFiles ]]
 	do
 		tagfiles+=("$line")
 		(( filecount++ ))
-		read -u4 -r -d $'\0' line
+		read -u4 line
 	done
 	echo 'BEGIN TRANSACTION;' >&3
 	for line in "${tagfiles[@]}"

lib/tasks/gettaskinfos

@@ -10,7 +10,7 @@ gettaskinfos() {
 		FROM	tasks
 		WHERE	id='$1';
 	' >&3
-	read -u4 -r -d $'\0' line
+	read -u4 line
 	taskid=${line%%::AtOM:SQL:Sep::*}
 	rest="${line#*::AtOM:SQL:Sep::}::AtOM:SQL:Sep::"
 	sourcefileid=${rest%%::AtOM:SQL:Sep::*}

lib/workers/create

@@ -2,7 +2,7 @@
 
 createworker() {
         (( ++active ))
-        read -u4 -r -d $'\0' line
+        read -u4 line
         taskid=${line%%::AtOM:SQL:Sep::*}
         rest="${line#*::AtOM:SQL:Sep::}::AtOM:SQL:Sep::"
         sourcefileid=${rest%%::AtOM:SQL:Sep::*}

lib/workers/master

@@ -10,7 +10,7 @@ master() {
 			WHERE	status = 0;
 		'>&3
 
-		read -u4 -r -d $'\0' remaining
+		read -u4 remaining
 		if (( remaining == 0 ))
 		then
 			sleep 0.1
@@ -108,7 +108,7 @@ master() {
 				LIMIT 1;
 			'>&3
 
-			read -u4 -r -d $'\0' ready
+			read -u4 ready
 			if (( ready > 0 ))
 			then
 				createworker
@@ -194,7 +194,7 @@ master() {
 				LIMIT 1;
 			' >&3
 
-			read -u4 -r -d $'\0' ready
+			read -u4 ready
 
 			if (( active == 0 && ready == 0 ))
 			then
@@ -234,7 +234,7 @@ master() {
 				WHERE	status = 0;
 			'>&3
 
-			read -u4 -r -d $'\0' remaining
+			read -u4 remaining
 		done
 	fi
 }

toys/checkextensions

@@ -121,7 +121,7 @@ getdstfiles() {
 			;
 			SELECT	"AtOM:NoMoreFiles";
 		'>&3
-		while read -u4 -r -d $'\0' line
+		while read -u4 line
 		do
 			if [[ $line == AtOM:NoMoreFiles ]]
 			then
@@ -159,7 +159,7 @@ renameFile() {
 	fi
 }
 
-while read -u4 -r -d $'\0' line
+while read -u4 line
 do
 	if [[ $line == AtOM:NoMoreFiles ]]
 	then

toys/checkmissing

@@ -65,7 +65,6 @@ getConfig
 sanityCheck
 openDatabase
 
-echo -n "Checking for missing files...  "
 echo '
 	SELECT 
 		destination_files.id,
@@ -80,7 +79,7 @@ echo 'SELECT "AtOM:NoMoreFiles";' >&3
 declare -a 			\
 	destination_names	\
 	files
-read -u4 -r -d $'\0' line
+read -u4 line
 until [[ $line == AtOM:NoMoreFiles ]]
 do
 	id=${line%%::AtOM:SQL:Sep::*}
@@ -88,11 +87,12 @@ do
 	destination_names[id]=${rest%%::AtOM:SQL:Sep::*}
 	rest=${rest#*::AtOM:SQL:Sep::}
 	files[id]=${rest}
-	read -u4 -r -d $'\0' line
+	read -u4 line
 done
 
 echo 'BEGIN TRANSACTION;' >&3
 
+echo -n "Checking for missing files...  "
 for index in "${!files[@]}"
 do
 	destination=${destination_names[index]}

toys/cleandestinations

@@ -65,22 +65,25 @@ getConfig
 sanityCheck
 openDatabase
 
+checkwanted() {
+	Select id <<<"filename = $1"
+}
+
 for destination in "${!destinationpath[@]}"
 do
 	echo -ne "\rScanning destination $destination...  \033[K"
-	while read -r -d $'\0' filename
+	while read -r filename
 	do
-		sqlfile=${filename//$'\n'/::AtOM:NewLine:SQL:Inline::}
 		if ! Select destination_files id	\
 			>/dev/null			\
-			<<<"filename = ${sqlfile#${destinationpath["$destination"]}/}"
+			<<<"filename = ${filename#${destinationpath["$destination"]}/}"
 		then
 			echo -e $'\r'"$filename\033[K"
-			(( remove )) && rm "$filename"
+			(( remove )) && rm -f "$filename"
 			echo -n "Scanning destination $destination...  "
 		fi
 		progressSpin
-	done < <(find "${destinationpath["$destination"]}" -type f -print0)
+	done < <(find "${destinationpath["$destination"]}" -type f)
 done
 echo -en "\r\033[K"
 

toys/createindex

@@ -274,7 +274,7 @@ fi
 echo 'SELECT IFNULL(
 	(SELECT last_seen FROM source_files ORDER BY last_seen DESC LIMIT 1),
 	0);' >&3
-read -u4 -r -d $'\0' lastupdate
+read -u4 lastupdate
 
 if ! [[ "$output" == - ]]
 then
@@ -369,11 +369,11 @@ COLLATE NOCASE;
 
 SELECT	"AtOM:NoMoreFiles";' >&3
 
-read -u4 -r -d $'\0' line
+read -u4 line
 until [[ $line == AtOM:NoMoreFiles ]]
 do
 	files+=("$line")
-	read -u4 -r -d $'\0' line
+	read -u4 line
 done
 
 for line in "${files[@]}"
@@ -675,7 +675,7 @@ echo '
 	
 SELECT	"AtOM:NoMoreFiles";' >&3
 
-read -u4 -r -d $'\0' line
+read -u4 line
 until [[ $line == AtOM:NoMoreFiles ]]
 do
 	artist="${line%%::AtOM:SQL:Sep::*}"
@@ -685,7 +685,7 @@ do
 	artists+=( "$artist" )
 	maxcountlen=$(( ${#count} > maxcountlen ? ${#count} : maxcountlen ))
 	maxartistlen=$(( ${#artist} > maxartistlen ? ${#artist} : maxartistlen ))
-	read -u4 -r -d $'\0' line
+	read -u4 line
 done
 head=$(
 	printf "|  # | %'${maxcoutlen}s | %-${maxartistlen}s |"	\
@@ -714,7 +714,7 @@ echo '
 	FROM		source_files
 	INNER JOIN	mime_types
 		ON	source_files.mime_type=mime_types.id;' >&3
-read -u4 -r -d $'\0' line
+read -u4 line
 totalcount="${line%%::AtOM:SQL:Sep::*}"
 maxcountlen=$(printf "%'i" $totalcount)
 maxcountlen=${#maxcountlen}
@@ -743,7 +743,7 @@ do
 		INNER JOIN	mime_types
 			ON	source_files.mime_type=mime_types.id
 		WHERE		mime_text LIKE "'"$format"'";' >&3
-	read -u4 -r -d $'\0' line
+	read -u4 line
 	count="${line%%::AtOM:SQL:Sep::*}"
 	rest="${line#*::AtOM:SQL:Sep::}::AtOM:SQL:Sep::"
 	size="${rest%%::AtOM:SQL:Sep::*}"

toys/lowquality

@@ -131,11 +131,11 @@ echo ') ORDER BY bitrate;' >&3
 
 echo 'SELECT "AtOM:NoMoreFiles";' >&3
 
-read -u4 -r -d $'\0' line
+read -u4 line
 until [[ $line == AtOM:NoMoreFiles ]]
 do
 	echo "${line//::AtOM:SQL:Sep::/$'\t'}"
-	read -u4 -r -d $'\0' line
+	read -u4 line
 done
 
 closeDatabase

toys/missingtags

@@ -149,11 +149,11 @@ cat >&3 <<-EOSelect
 	SELECT	"AtOM:NoMoreFiles";
 EOSelect
 
-read -u4 -r -d $'\0' line
+read -u4 line
 until [[ $line == AtOM:NoMoreFiles ]]
 do
 	lines+=( "$line" )
-	read -u4 -r -d $'\0' line
+	read -u4 line
 done
 
 for line in "${lines[@]}"